Configuration externalization#33
Open
juliendangers wants to merge 4 commits intonode-freight:masterfrom
iadvize:configurationExternalization
Open
Configuration externalization#33juliendangers wants to merge 4 commits intonode-freight:masterfrom iadvize:configurationExternalization
juliendangers wants to merge 4 commits intonode-freight:masterfrom
iadvize:configurationExternalization
Conversation
Member
|
Anything else you wanted in this PR? Redis config? |
Contributor
Author
|
@vladikoff do you think it's a good idea to drop automatic password generation ? Shouldn't we generate one if not set in env variable or configuration file ? |
Member
Yeah I like the functionality, can we keep it? |
Contributor
Author
|
👍 I could try to generate a new password if it's not set through env variable or configuration file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid having to create a specific file for each environment, and to be able to deploy multiple freight-server instances with different configurations, it is easier to be able to provide configuration from environment variables. It is also easier to use with docker
I still need to find a way to extract redis options, but file can used for that at the moment.
I still need to update README to explain password is empty by default, and I may need to update tests accordingly (I'll do it today).